homatthew commented on code in PR #3843:
URL: https://github.com/apache/gobblin/pull/3843#discussion_r1470388235
##########
gobblin-temporal/src/main/java/org/apache/gobblin/temporal/GobblinTemporalConfigurationKeys.java:
##########
@@ -43,6 +43,13 @@ public interface GobblinTemporalConfigurationKeys {
String GOBBLIN_TEMPORAL_JOB_LAUNCHER_ARG_PREFIX =
GOBBLIN_TEMPORAL_JOB_LAUNCHER_PREFIX + "arg.";
+ /**
+ * Suffix for metrics emitted by GobblinTemporalJobLauncher for preventing
collisions with prod jobs
+ * during testing
+ */
+ String GOBBLIN_TEMPORAL_JOB_METRICS_SUFFIX = PREFIX + "job.metrics.suffix";
+ String DEFAULT_GOBBLIN_TEMPORAL_JOB_METRICS_SUFFIX = "";
Review Comment:
Since we are still in alpha stages, I'd imagine it's okay to have the
default include a suffix. But obviously we'd need a TODO for reverting that
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]