homatthew commented on code in PR #3843:
URL: https://github.com/apache/gobblin/pull/3843#discussion_r1449739487


##########
gobblin-metrics-libs/gobblin-metrics-base/src/main/java/org/apache/gobblin/metrics/Tag.java:
##########
@@ -21,14 +21,15 @@
 import java.util.List;
 import java.util.Map;
 
-import javax.annotation.Nullable;
-
+import com.fasterxml.jackson.annotation.JsonCreator;
 import com.google.common.base.Function;
 import com.google.common.base.Splitter;
 import com.google.common.collect.ImmutableList;
 import com.google.common.collect.ImmutableMap;
 import com.google.common.collect.Lists;
 
+import javax.annotation.Nullable;

Review Comment:
   ```
   <option name="IMPORT_LAYOUT_TABLE">
     <value>
       <package name="java" withSubpackages="true" static="false"/>
       <emptyLine/>
       <package name="org" withSubpackages="true" static="false"/>
       <emptyLine/>
       <package name="com" withSubpackages="true" static="false"/>
       <emptyLine/>
       <package name="" withSubpackages="true" static="false"/>
       <emptyLine/>
       <package name="org.apache.gobblin" withSubpackages="true" 
static="false"/>
       <emptyLine/>
       <package name="" withSubpackages="true" static="true"/>
     </value>
   </option>
   ```
   
   From 
https://gobblin.apache.org/docs/developer-guide/files/codestyle-intellij-gobblin.xml
 (imported on xml)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to