[
https://issues.apache.org/jira/browse/GOBBLIN-1990?focusedWorklogId=901069&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-901069
]
ASF GitHub Bot logged work on GOBBLIN-1990:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 22/Jan/24 23:33
Start Date: 22/Jan/24 23:33
Worklog Time Spent: 10m
Work Description: arjun4084346 commented on code in PR #3864:
URL: https://github.com/apache/gobblin/pull/3864#discussion_r1462554255
##########
gobblin-service/src/test/java/org/apache/gobblin/service/GobblinServiceManagerTest.java:
##########
@@ -359,40 +364,57 @@ public void testRunQuotaExceeds() throws Exception {
try {
this.flowConfigClient.createFlowConfig(flowConfig2);
} catch (RestLiResponseException e) {
+ /* Note: this exception may NOT occur if the first job above is
processed immediately so TEST_FLOW_ID2 will remain
Review Comment:
I think, if this call does not always create RestLiResponseException, we
should not have this unit test at all.
Or we can simulate the job the first job to run longer.
and +1 to the comment
Issue Time Tracking
-------------------
Worklog Id: (was: 901069)
Time Spent: 0.5h (was: 20m)
> Update GobblinServiceManagerTest to reduce flakiness
> ----------------------------------------------------
>
> Key: GOBBLIN-1990
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1990
> Project: Apache Gobblin
> Issue Type: Bug
> Components: gobblin-service
> Reporter: Urmi Mustafi
> Assignee: Abhishek Tiwari
> Priority: Major
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> {{GobblinServiceManager}} tests are timing dependent and depend on state from
> other unit tests. They frequently fail, showing different results on IDE
> versus run in terminal with Gradle. We don't want to disable too many of them
> since they are useful. However, we want to remove timing dependent tests and
> decouple the tests so they do not depend on state from another test.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)