[
https://issues.apache.org/jira/browse/GOBBLIN-1990?focusedWorklogId=901077&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-901077
]
ASF GitHub Bot logged work on GOBBLIN-1990:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 23/Jan/24 00:07
Start Date: 23/Jan/24 00:07
Worklog Time Spent: 10m
Work Description: umustafi commented on code in PR #3864:
URL: https://github.com/apache/gobblin/pull/3864#discussion_r1462573450
##########
gobblin-service/src/test/java/org/apache/gobblin/service/GobblinServiceManagerTest.java:
##########
@@ -328,23 +328,28 @@ public void testUncompilableJob() throws Exception {
Assert.assertFalse(this.gobblinServiceManager.getScheduler().getScheduledFlowSpecs().containsKey(uri.toString()));
}
- @Test (dependsOnMethods = "testUncompilableJob")
+ // Disabled because of timing issue with scheduler
+ @Test (dependsOnMethods = "testUncompilableJob", enabled = false, groups =
{"disabledOnCI"})
public void testRunOnceJob() throws Exception {
FlowConfig flowConfig = new FlowConfig().setId(TEST_FLOW_ID)
.setTemplateUris(TEST_TEMPLATE_URI).setProperties(new
StringMap(flowProperties));
this.flowConfigClient.createFlowConfig(flowConfig);
// runOnce job is deleted soon after it is orchestrated
-
AssertWithBackoff.create().maxSleepMs(200L).timeoutMs(2000L).backoffFactor(1)
+
AssertWithBackoff.create().maxSleepMs(200L).timeoutMs(60000L).backoffFactor(1)
.assertTrue(input ->
this.gobblinServiceManager.getFlowCatalog().getSpecs().size() == 0,
"Waiting for job to get orchestrated...");
-
AssertWithBackoff.create().maxSleepMs(100L).timeoutMs(1000L).backoffFactor(1)
+
AssertWithBackoff.create().maxSleepMs(100L).timeoutMs(2000L).backoffFactor(1)
.assertTrue(input ->
!this.gobblinServiceManager.getScheduler().getScheduledFlowSpecs().containsKey(TEST_URI.toString()),
"Waiting for job to get orchestrated...");
+
AssertWithBackoff.create().maxSleepMs(200L).timeoutMs(2000L).backoffFactor(1)
+ .assertTrue(input ->
!this.gobblinServiceManager.getScheduler().getLastUpdatedTimeForFlowSpec().containsKey(TEST_URI.toString()),
+ "Waiting for job to get orchestrated...");
}
- @Test (dependsOnMethods = "testRunOnceJob")
+ // Disabled because whether the test will raise the 503 exception is timing
dependent
Review Comment:
I tried using AssertWithBackoff but it ends up being cleaned _too_ quickly
is the issue I believe
Issue Time Tracking
-------------------
Worklog Id: (was: 901077)
Time Spent: 1h 10m (was: 1h)
> Update GobblinServiceManagerTest to reduce flakiness
> ----------------------------------------------------
>
> Key: GOBBLIN-1990
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1990
> Project: Apache Gobblin
> Issue Type: Bug
> Components: gobblin-service
> Reporter: Urmi Mustafi
> Assignee: Abhishek Tiwari
> Priority: Major
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> {{GobblinServiceManager}} tests are timing dependent and depend on state from
> other unit tests. They frequently fail, showing different results on IDE
> versus run in terminal with Gradle. We don't want to disable too many of them
> since they are useful. However, we want to remove timing dependent tests and
> decouple the tests so they do not depend on state from another test.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)