[ 
https://issues.apache.org/jira/browse/GOBBLIN-1990?focusedWorklogId=901260&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-901260
 ]

ASF GitHub Bot logged work on GOBBLIN-1990:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 23/Jan/24 19:16
            Start Date: 23/Jan/24 19:16
    Worklog Time Spent: 10m 
      Work Description: Will-Lo commented on code in PR #3864:
URL: https://github.com/apache/gobblin/pull/3864#discussion_r1463870595


##########
gobblin-service/src/test/java/org/apache/gobblin/service/GobblinServiceManagerTest.java:
##########
@@ -359,40 +364,57 @@ public void testRunQuotaExceeds() throws Exception {
     try {
       this.flowConfigClient.createFlowConfig(flowConfig2);
     } catch (RestLiResponseException e) {
+      /* Note: this exception may NOT occur if the first job above is 
processed immediately so TEST_FLOW_ID2 will remain

Review Comment:
   If we need this test again it should be something like a quota + allowing 
concurrent scheduled flows, this way it ensures that there is no 
cleanup/retention and then it can be reproducible. 





Issue Time Tracking
-------------------

    Worklog Id:     (was: 901260)
    Time Spent: 2h  (was: 1h 50m)

> Update GobblinServiceManagerTest to reduce flakiness
> ----------------------------------------------------
>
>                 Key: GOBBLIN-1990
>                 URL: https://issues.apache.org/jira/browse/GOBBLIN-1990
>             Project: Apache Gobblin
>          Issue Type: Bug
>          Components: gobblin-service
>            Reporter: Urmi Mustafi
>            Assignee: Abhishek Tiwari
>            Priority: Major
>          Time Spent: 2h
>  Remaining Estimate: 0h
>
> {{GobblinServiceManager}} tests are timing dependent and depend on state from 
> other unit tests. They frequently fail, showing different results on IDE 
> versus run in terminal with Gradle. We don't want to disable too many of them 
> since they are useful. However, we want to remove timing dependent tests and 
> decouple the tests so they do not depend on state from another test.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to