homatthew commented on code in PR #3865:
URL: https://github.com/apache/gobblin/pull/3865#discussion_r1473039705


##########
gobblin-runtime/src/main/java/org/apache/gobblin/runtime/app/ServiceBasedAppLauncher.java:
##########
@@ -163,9 +170,17 @@ public void run() {
     });
 
     LOG.info("Starting the Gobblin application and all its associated 
Services");
+    for (Service service : this.services) {
+      LOG.info("Starting service " + service.getClass().getSimpleName());
+    }
 
     // Start the application
-    this.serviceManager.startAsync().awaitHealthy();
+    try {
+      
this.serviceManager.startAsync().awaitHealthy(startupTimeout.getSeconds(), 
TimeUnit.SECONDS);

Review Comment:
   One of the services, the FSConfigurationManager, has some main thread 
interrupting behavior that causes the start call to last indefinitely. 
   
   This prevents users from being able to call the shutdown method because this 
method is synchronized. I'm adding a configuration for the timeout to be 
configurable, with the default being indefinitely waiting



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to