phet commented on code in PR #3865:
URL: https://github.com/apache/gobblin/pull/3865#discussion_r1473408282
##########
gobblin-temporal/src/main/java/org/apache/gobblin/temporal/joblauncher/GobblinJobLauncher.java:
##########
@@ -206,6 +206,13 @@ public void launchJob(@Nullable JobListener jobListener)
throws JobException {
cancelJob(jobListener);
}
} finally {
+ // NOTE: This code only makes sense when there is 1 source / workflow
being launched per application. This is a stop-gap
+ // for recreating batch job behavior in GaaS. Given the current
constraints of yarn applications requiring a static proxy user
+ // during application creation, it is not possible to have multiple
workflows running in the same application.
+ // and so it makes sense ti just kill the job after this is complete
+ log.info("Requesting the AM to shutdown after the job {} completed",
this.jobContext.getJobId());
+ eventBus.post(new ClusterManagerShutdownRequest());
Review Comment:
is it ok to always doing this, even w/o checking `isLaunched`?
##########
gobblin-temporal/src/main/java/org/apache/gobblin/temporal/joblauncher/GobblinJobLauncher.java:
##########
@@ -206,6 +206,13 @@ public void launchJob(@Nullable JobListener jobListener)
throws JobException {
cancelJob(jobListener);
}
} finally {
+ // NOTE: This code only makes sense when there is 1 source / workflow
being launched per application. This is a stop-gap
+ // for recreating batch job behavior in GaaS. Given the current
constraints of yarn applications requiring a static proxy user
+ // during application creation, it is not possible to have multiple
workflows running in the same application.
+ // and so it makes sense ti just kill the job after this is complete
+ log.info("Requesting the AM to shutdown after the job {} completed",
this.jobContext.getJobId());
+ eventBus.post(new ClusterManagerShutdownRequest());
Review Comment:
is it ok to always perform, even w/o first checking `isLaunched`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]