homatthew commented on code in PR #3865:
URL: https://github.com/apache/gobblin/pull/3865#discussion_r1473042074
##########
gobblin-temporal/src/main/java/org/apache/gobblin/temporal/cluster/GobblinTemporalClusterManager.java:
##########
@@ -152,7 +141,7 @@ private void initializeAppLauncherAndServices() throws
Exception {
if (!properties.contains(ServiceBasedAppLauncher.APP_STOP_TIME_SECONDS)) {
properties.setProperty(ServiceBasedAppLauncher.APP_STOP_TIME_SECONDS,
Long.toString(300));
}
- this.applicationLauncher = new ServiceBasedAppLauncher(properties,
this.clusterName);
+ this.applicationLauncher = new
ServiceBasedAppLauncherWithoutMetrics(properties, this.clusterName);
Review Comment:
Metrics in these pipelines are causing noisy logging and the metrics here
are currently not used by Temporal this temporal in any meaningful way, so I've
disabled them here.
Disabling metrics via the gobblin metris key is not desirable because we
still need GTE emission to work
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]