homatthew commented on code in PR #3865:
URL: https://github.com/apache/gobblin/pull/3865#discussion_r1487017070


##########
gobblin-temporal/src/main/java/org/apache/gobblin/temporal/workflows/metrics/TemporalEventTimer.java:
##########
@@ -70,7 +70,9 @@ private static Instant getCurrentTime() {
   }
 
   public static class Factory {
-    private static final ActivityOptions DEFAULT_OPTS = 
ActivityOptions.newBuilder().build();
+    private static final ActivityOptions DEFAULT_OPTS = 
ActivityOptions.newBuilder()
+        .setStartToCloseTimeout(Duration.ofHours(24))

Review Comment:
   Correct. the job itself can still run for > 24 hours. But if for some reason 
kafka is down, this operation can take an arbitrary amount of time. So let's 
cap it at a reasonably high number (24 hours)
   
   There are 2 things to consider here:
   1. GaaS won't be able to detect if a job has finished until this activity 
succeeds. If Kafka is down, we want to be able to retry this task until kafka 
is back.
   2. If the job itself is completed but this timer is unable to send the 
message, I think 24 hours is a reasonable amount of time to retry for before 
giving up. We ideally don't want to have to retry the work just because the 
timer failed for a brief period of time (e.g. a few hours of downtime)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to