homatthew commented on code in PR #3865:
URL: https://github.com/apache/gobblin/pull/3865#discussion_r1480406863


##########
gobblin-runtime/src/main/java/org/apache/gobblin/runtime/app/ServiceBasedAppLauncher.java:
##########
@@ -75,6 +78,8 @@ public class ServiceBasedAppLauncher implements 
ApplicationLauncher {
    * The name of the application. Not applicable for YARN jobs, which uses a 
separate key for the application name.
    */
   public static final String APP_NAME = "app.name";
+  public static final String STARTUP_TIMEOUT = 
"app.start.waitForServices.seconds";
+  public static final Duration DEFAULT_STARTUP_TIMEOUT = 
ChronoUnit.FOREVER.getDuration();

Review Comment:
   forever is the current behavior is the legacy behavior. I think it's worth 
keeping that blocking behavior for other users of this class. And then we can 
override this behavior if necessary



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to