phet commented on code in PR #3865:
URL: https://github.com/apache/gobblin/pull/3865#discussion_r1487359198
##########
gobblin-temporal/src/main/java/org/apache/gobblin/temporal/workflows/metrics/TemporalEventTimer.java:
##########
@@ -70,7 +70,9 @@ private static Instant getCurrentTime() {
}
public static class Factory {
- private static final ActivityOptions DEFAULT_OPTS =
ActivityOptions.newBuilder().build();
+ private static final ActivityOptions DEFAULT_OPTS =
ActivityOptions.newBuilder()
+ .setStartToCloseTimeout(Duration.ofHours(24))
Review Comment:
sure that's fine. for this, even 8 or 12 hours should be far sufficient.
please add clarifying comment that this is max time to attempt to send,
potentially waiting out a kafka outage
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]