[jira] [Work logged] (GOBBLIN-1996) Add ability for Yarn app to terminate on finishing of temporal flow

[ASF GitHub Bot (Jira)]

     [ 
https://issues.apache.org/jira/browse/GOBBLIN-1996?focusedWorklogId=904690&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-904690
 ]

ASF GitHub Bot logged work on GOBBLIN-1996:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 13/Feb/24 07:56
            Start Date: 13/Feb/24 07:56
    Worklog Time Spent: 10m 
      Work Description: phet commented on code in PR #3865:
URL: https://github.com/apache/gobblin/pull/3865#discussion_r1487359198


##########
gobblin-temporal/src/main/java/org/apache/gobblin/temporal/workflows/metrics/TemporalEventTimer.java:
##########
@@ -70,7 +70,9 @@ private static Instant getCurrentTime() {
   }
 
   public static class Factory {
-    private static final ActivityOptions DEFAULT_OPTS = 
ActivityOptions.newBuilder().build();
+    private static final ActivityOptions DEFAULT_OPTS = 
ActivityOptions.newBuilder()
+        .setStartToCloseTimeout(Duration.ofHours(24))

Review Comment:
   sure that's fine.  for this, even 8 or 12 hours should be far sufficient.  
please add clarifying comment that this is max time to attempt to send, 
potentially waiting out a kafka outage





Issue Time Tracking
-------------------

    Worklog Id:     (was: 904690)
    Time Spent: 4h 20m  (was: 4h 10m)

> Add ability for Yarn app to terminate on finishing of temporal flow
> -------------------------------------------------------------------
>
>                 Key: GOBBLIN-1996
>                 URL: https://issues.apache.org/jira/browse/GOBBLIN-1996
>             Project: Apache Gobblin
>          Issue Type: Improvement
>            Reporter: Matthew Ho
>            Priority: Major
>          Time Spent: 4h 20m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)