[
https://issues.apache.org/jira/browse/GOBBLIN-1996?focusedWorklogId=904765&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-904765
]
ASF GitHub Bot logged work on GOBBLIN-1996:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 13/Feb/24 18:48
Start Date: 13/Feb/24 18:48
Worklog Time Spent: 10m
Work Description: codecov-commenter commented on PR #3865:
URL: https://github.com/apache/gobblin/pull/3865#issuecomment-1942180624
##
[Codecov](https://app.codecov.io/gh/apache/gobblin/pull/3865?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
Report
Attention: `43 lines` in your changes are missing coverage. Please review.
> Comparison is base
[(`aec3401`)](https://app.codecov.io/gh/apache/gobblin/commit/aec34013b19e7aed4f6a522635552415111c6999?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
0.00% compared to head
[(`6239d42`)](https://app.codecov.io/gh/apache/gobblin/pull/3865?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
46.72%.
> Report is 3 commits behind head on master.
|
[Files](https://app.codecov.io/gh/apache/gobblin/pull/3865?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
| Patch % | Lines |
|---|---|---|
|
[...obblin/temporal/ddm/NoWorkUnitsInfiniteSource.java](https://app.codecov.io/gh/apache/gobblin/pull/3865?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z29iYmxpbi10ZW1wb3JhbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZ29iYmxpbi90ZW1wb3JhbC9kZG0vTm9Xb3JrVW5pdHNJbmZpbml0ZVNvdXJjZS5qYXZh)
| 0.00% | [12 Missing :warning:
](https://app.codecov.io/gh/apache/gobblin/pull/3865?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
|
|
[...emporal/cluster/GobblinTemporalClusterManager.java](https://app.codecov.io/gh/apache/gobblin/pull/3865?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z29iYmxpbi10ZW1wb3JhbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZ29iYmxpbi90ZW1wb3JhbC9jbHVzdGVyL0dvYmJsaW5UZW1wb3JhbENsdXN0ZXJNYW5hZ2VyLmphdmE=)
| 0.00% | [9 Missing :warning:
](https://app.codecov.io/gh/apache/gobblin/pull/3865?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
|
|
[...e/gobblin/runtime/app/ServiceBasedAppLauncher.java](https://app.codecov.io/gh/apache/gobblin/pull/3865?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvYXBwL1NlcnZpY2VCYXNlZEFwcExhdW5jaGVyLmphdmE=)
| 66.66% | [3 Missing and 1 partial :warning:
](https://app.codecov.io/gh/apache/gobblin/pull/3865?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
|
|
[...mporal/joblauncher/GobblinTemporalJobLauncher.java](https://app.codecov.io/gh/apache/gobblin/pull/3865?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z29iYmxpbi10ZW1wb3JhbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZ29iYmxpbi90ZW1wb3JhbC9qb2JsYXVuY2hlci9Hb2JibGluVGVtcG9yYWxKb2JMYXVuY2hlci5qYXZh)
| 0.00% | [4 Missing :warning:
](https://app.codecov.io/gh/apache/gobblin/pull/3865?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
|
|
[...cluster/ServiceBasedAppLauncherWithoutMetrics.java](https://app.codecov.io/gh/apache/gobblin/pull/3865?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z29iYmxpbi10ZW1wb3JhbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZ29iYmxpbi90ZW1wb3JhbC9jbHVzdGVyL1NlcnZpY2VCYXNlZEFwcExhdW5jaGVyV2l0aG91dE1ldHJpY3MuamF2YQ==)
| 0.00% | [3 Missing :warning:
](https://app.codecov.io/gh/apache/gobblin/pull/3865?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
|
|
[...bblin/temporal/joblauncher/GobblinJobLauncher.java](https://app.codecov.io/gh/apache/gobblin/pull/3865?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z29iYmxpbi10ZW1wb3JhbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZ29iYmxpbi90ZW1wb3JhbC9qb2JsYXVuY2hlci9Hb2JibGluSm9iTGF1bmNoZXIuamF2YQ==)
| 0.00% | [3 Missing :warning:
](https://app.codecov.io/gh/apache/gobblin/pull/3865?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
|
|
[...temporal/workflows/metrics/TemporalEventTimer.java](https://app.codecov.io/gh/apache/gobblin/pull/3865?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z29iYmxpbi10ZW1wb3JhbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZ29iYmxpbi90ZW1wb3JhbC93b3JrZmxvd3MvbWV0cmljcy9UZW1wb3JhbEV2ZW50VGltZXIuamF2YQ==)
| 0.00% | [3 Missing :warning:
](https://app.codecov.io/gh/apache/gobblin/pull/3865?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
|
|
[.../org/apache/gobblin/temporal/yarn/YarnService.java](https://app.codecov.io/gh/apache/gobblin/pull/3865?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z29iYmxpbi10ZW1wb3JhbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZ29iYmxpbi90ZW1wb3JhbC95YXJuL1lhcm5TZXJ2aWNlLmphdmE=)
| 0.00% | [2 Missing :warning:
](https://app.codecov.io/gh/apache/gobblin/pull/3865?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
|
|
[...oral/ddm/launcher/ProcessWorkUnitsJobLauncher.java](https://app.codecov.io/gh/apache/gobblin/pull/3865?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z29iYmxpbi10ZW1wb3JhbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZ29iYmxpbi90ZW1wb3JhbC9kZG0vbGF1bmNoZXIvUHJvY2Vzc1dvcmtVbml0c0pvYkxhdW5jaGVyLmphdmE=)
| 0.00% | [1 Missing :warning:
](https://app.codecov.io/gh/apache/gobblin/pull/3865?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
|
|
[.../loadgen/launcher/GenArbitraryLoadJobLauncher.java](https://app.codecov.io/gh/apache/gobblin/pull/3865?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z29iYmxpbi10ZW1wb3JhbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZ29iYmxpbi90ZW1wb3JhbC9sb2FkZ2VuL2xhdW5jaGVyL0dlbkFyYml0cmFyeUxvYWRKb2JMYXVuY2hlci5qYXZh)
| 0.00% | [1 Missing :warning:
](https://app.codecov.io/gh/apache/gobblin/pull/3865?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
|
| ... and [1
more](https://app.codecov.io/gh/apache/gobblin/pull/3865?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
| |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #3865 +/- ##
=============================================
+ Coverage 0 46.72% +46.72%
- Complexity 0 11131 +11131
=============================================
Files 0 2212 +2212
Lines 0 87430 +87430
Branches 0 9613 +9613
=============================================
+ Hits 0 40855 +40855
- Misses 0 42884 +42884
- Partials 0 3691 +3691
```
</details>
[:umbrella: View full report in Codecov by
Sentry](https://app.codecov.io/gh/apache/gobblin/pull/3865?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it
here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
Issue Time Tracking
-------------------
Worklog Id: (was: 904765)
Time Spent: 4h 40m (was: 4.5h)
> Add ability for Yarn app to terminate on finishing of temporal flow
> -------------------------------------------------------------------
>
> Key: GOBBLIN-1996
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1996
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Matthew Ho
> Priority: Major
> Time Spent: 4h 40m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
