[
https://issues.apache.org/jira/browse/GOBBLIN-1996?focusedWorklogId=903941&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-903941
]
ASF GitHub Bot logged work on GOBBLIN-1996:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 06/Feb/24 18:58
Start Date: 06/Feb/24 18:58
Worklog Time Spent: 10m
Work Description: homatthew commented on code in PR #3865:
URL: https://github.com/apache/gobblin/pull/3865#discussion_r1480406863
##########
gobblin-runtime/src/main/java/org/apache/gobblin/runtime/app/ServiceBasedAppLauncher.java:
##########
@@ -75,6 +78,8 @@ public class ServiceBasedAppLauncher implements
ApplicationLauncher {
* The name of the application. Not applicable for YARN jobs, which uses a
separate key for the application name.
*/
public static final String APP_NAME = "app.name";
+ public static final String STARTUP_TIMEOUT =
"app.start.waitForServices.seconds";
+ public static final Duration DEFAULT_STARTUP_TIMEOUT =
ChronoUnit.FOREVER.getDuration();
Review Comment:
forever is the current behavior is the legacy behavior. I think it's worth
keeping that blocking behavior for other users of this class. And then we can
override this behavior if necessary
Issue Time Tracking
-------------------
Worklog Id: (was: 903941)
Time Spent: 3h (was: 2h 50m)
> Add ability for Yarn app to terminate on finishing of temporal flow
> -------------------------------------------------------------------
>
> Key: GOBBLIN-1996
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1996
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Matthew Ho
> Priority: Major
> Time Spent: 3h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
