umustafi commented on code in PR #3892:
URL: https://github.com/apache/gobblin/pull/3892#discussion_r1520527390
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/scheduler/GobblinServiceJobScheduler.java:
##########
@@ -168,14 +170,17 @@ public class GobblinServiceJobScheduler extends
JobScheduler implements SpecCata
* so only they would be loaded during DR handling.
*/
public static final String DR_FILTER_TAG = "dr";
+ private final boolean dagProcessingEngineEnabled;
+ private final DagManagement dagManagement;
@Inject
public GobblinServiceJobScheduler(@Named(InjectionNames.SERVICE_NAME) String
serviceName,
Config config,
Optional<HelixManager> helixManager, Optional<FlowCatalog> flowCatalog,
Orchestrator orchestrator, SchedulerService schedulerService,
Optional<UserQuotaManager> quotaManager, Optional<Logger> log,
@Named(InjectionNames.WARM_STANDBY_ENABLED) boolean isWarmStandbyEnabled,
- Optional<FlowTriggerHandler> flowTriggerHandler) throws Exception {
+ Optional<FlowTriggerHandler> flowTriggerHandler, DagManagement
dagManagement,
Review Comment:
it's also clearer into to have an optional DagManagement object that is
present only when the engine is enabled but it's open to debate
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
