phet commented on code in PR #3892: URL: https://github.com/apache/gobblin/pull/3892#discussion_r1520801829
########## gobblin-service/src/main/java/org/apache/gobblin/service/modules/scheduler/GobblinServiceJobScheduler.java: ########## @@ -120,7 +122,7 @@ public class GobblinServiceJobScheduler extends JobScheduler implements SpecCata protected final Optional<UserQuotaManager> quotaManager; protected final Optional<FlowTriggerHandler> flowTriggerHandler; @Getter - protected final Map<String, Spec> scheduledFlowSpecs; + protected final Map<String, FlowSpec> scheduledFlowSpecs; Review Comment: NBD, this may be for the best... but I can't seem to figure out: where is the initial motivation coming in? e.g. I was looking for a changed method signature, but didn't notice one. is it entirely a preference to change the type of these various members? (again, I'm not calling into question the decision to change, more wanting to understand motivation for the decision.) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
