phet commented on code in PR #3892:
URL: https://github.com/apache/gobblin/pull/3892#discussion_r1520864260


##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/scheduler/GobblinServiceJobScheduler.java:
##########
@@ -120,7 +122,7 @@ public class GobblinServiceJobScheduler extends 
JobScheduler implements SpecCata
   protected final Optional<UserQuotaManager> quotaManager;
   protected final Optional<FlowTriggerHandler> flowTriggerHandler;
   @Getter
-  protected final Map<String, Spec> scheduledFlowSpecs;
+  protected final Map<String, FlowSpec> scheduledFlowSpecs;

Review Comment:
   aah, ok, I see - so essentially just following more widely the 
specific-derived-class (`FlowSpec`) typing instituted therein.
   
   (I like the increased clarity)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to