[
https://issues.apache.org/jira/browse/GOBBLIN-2013?focusedWorklogId=909301&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-909301
]
ASF GitHub Bot logged work on GOBBLIN-2013:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 11/Mar/24 23:11
Start Date: 11/Mar/24 23:11
Worklog Time Spent: 10m
Work Description: umustafi commented on code in PR #3892:
URL: https://github.com/apache/gobblin/pull/3892#discussion_r1520527390
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/scheduler/GobblinServiceJobScheduler.java:
##########
@@ -168,14 +170,17 @@ public class GobblinServiceJobScheduler extends
JobScheduler implements SpecCata
* so only they would be loaded during DR handling.
*/
public static final String DR_FILTER_TAG = "dr";
+ private final boolean dagProcessingEngineEnabled;
+ private final DagManagement dagManagement;
@Inject
public GobblinServiceJobScheduler(@Named(InjectionNames.SERVICE_NAME) String
serviceName,
Config config,
Optional<HelixManager> helixManager, Optional<FlowCatalog> flowCatalog,
Orchestrator orchestrator, SchedulerService schedulerService,
Optional<UserQuotaManager> quotaManager, Optional<Logger> log,
@Named(InjectionNames.WARM_STANDBY_ENABLED) boolean isWarmStandbyEnabled,
- Optional<FlowTriggerHandler> flowTriggerHandler) throws Exception {
+ Optional<FlowTriggerHandler> flowTriggerHandler, DagManagement
dagManagement,
Review Comment:
it's also clearer into to have an optional DagManagement object that is
present only when the engine is enabled but it's open to debate
Issue Time Tracking
-------------------
Worklog Id: (was: 909301)
Time Spent: 20m (was: 10m)
> create instances of new new class created in PR #3858
> -----------------------------------------------------
>
> Key: GOBBLIN-2013
> URL: https://issues.apache.org/jira/browse/GOBBLIN-2013
> Project: Apache Gobblin
> Issue Type: Task
> Reporter: Arjun Singh Bora
> Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
