[
https://issues.apache.org/jira/browse/GOBBLIN-2013?focusedWorklogId=909329&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-909329
]
ASF GitHub Bot logged work on GOBBLIN-2013:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 12/Mar/24 03:30
Start Date: 12/Mar/24 03:30
Worklog Time Spent: 10m
Work Description: phet commented on code in PR #3892:
URL: https://github.com/apache/gobblin/pull/3892#discussion_r1520800531
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/scheduler/GobblinServiceJobScheduler.java:
##########
@@ -168,14 +170,17 @@ public class GobblinServiceJobScheduler extends
JobScheduler implements SpecCata
* so only they would be loaded during DR handling.
*/
public static final String DR_FILTER_TAG = "dr";
+ private final boolean dagProcessingEngineEnabled;
+ private final DagManagement dagManagement;
@Inject
public GobblinServiceJobScheduler(@Named(InjectionNames.SERVICE_NAME) String
serviceName,
Config config,
Optional<HelixManager> helixManager, Optional<FlowCatalog> flowCatalog,
Orchestrator orchestrator, SchedulerService schedulerService,
Optional<UserQuotaManager> quotaManager, Optional<Logger> log,
@Named(InjectionNames.WARM_STANDBY_ENABLED) boolean isWarmStandbyEnabled,
- Optional<FlowTriggerHandler> flowTriggerHandler) throws Exception {
+ Optional<FlowTriggerHandler> flowTriggerHandler, DagManagement
dagManagement,
Review Comment:
I'd whole-heartedly urge us to ONLY create required instances. otherwise a
not-yet-ready-for-prod instance that fails creation can bring down the entire
application. best practice is to guard significant new/reworked functionality
behind config, and this includes initialization
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/scheduler/GobblinServiceJobScheduler.java:
##########
@@ -120,7 +122,7 @@ public class GobblinServiceJobScheduler extends
JobScheduler implements SpecCata
protected final Optional<UserQuotaManager> quotaManager;
protected final Optional<FlowTriggerHandler> flowTriggerHandler;
@Getter
- protected final Map<String, Spec> scheduledFlowSpecs;
+ protected final Map<String, FlowSpec> scheduledFlowSpecs;
Review Comment:
NBD, this may be for the best... but I can't seem to figure out: where is
the initial motivation coming in? e.g. I was looking for a changed method
signature, but didn't notice one. is it entirely a preference to change the
type of these various members? (again, I'm not calling into question the
decision to change, more wanting to understand motivation for the decision.)
Issue Time Tracking
-------------------
Worklog Id: (was: 909329)
Time Spent: 40m (was: 0.5h)
> create instances of new new class created in PR #3858
> -----------------------------------------------------
>
> Key: GOBBLIN-2013
> URL: https://issues.apache.org/jira/browse/GOBBLIN-2013
> Project: Apache Gobblin
> Issue Type: Task
> Reporter: Arjun Singh Bora
> Priority: Major
> Time Spent: 40m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
