[
https://issues.apache.org/jira/browse/GOBBLIN-2013?focusedWorklogId=909346&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-909346
]
ASF GitHub Bot logged work on GOBBLIN-2013:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 12/Mar/24 05:19
Start Date: 12/Mar/24 05:19
Worklog Time Spent: 10m
Work Description: phet commented on code in PR #3892:
URL: https://github.com/apache/gobblin/pull/3892#discussion_r1520856867
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/proc/LaunchDagProc.java:
##########
@@ -45,9 +45,9 @@ public class LaunchDagProc extends
DagProc<Optional<Dag<JobExecutionPlan>>, Opti
public LaunchDagProc(LaunchDagTask launchDagTask) {
this.launchDagTask = launchDagTask;
this.orchestrationDelayCounter = new AtomicLong(0);
- ContextAwareGauge<Long> orchestrationDelayMetric =
this.metricContext.newContextAwareGauge
+ ContextAwareGauge<Long> orchestrationDelayMetric =
metricContext.newContextAwareGauge
(ServiceMetricNames.FLOW_ORCHESTRATION_DELAY,
orchestrationDelayCounter::get);
- this.metricContext.register(orchestrationDelayMetric);
+ metricContext.register(orchestrationDelayMetric);
Review Comment:
why change how it's referenced... isn't `metricContext` still an instance
member?
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/scheduler/GobblinServiceJobScheduler.java:
##########
@@ -120,7 +122,7 @@ public class GobblinServiceJobScheduler extends
JobScheduler implements SpecCata
protected final Optional<UserQuotaManager> quotaManager;
protected final Optional<FlowTriggerHandler> flowTriggerHandler;
@Getter
- protected final Map<String, Spec> scheduledFlowSpecs;
+ protected final Map<String, FlowSpec> scheduledFlowSpecs;
Review Comment:
aah, ok, I see - so essentially just following more widely the
specific-derived-class (`FlowSpec`) typing instituted therein
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/Orchestrator.java:
##########
@@ -111,14 +111,13 @@ public class Orchestrator implements SpecCatalogListener,
Instrumentable {
@Getter
private final SharedFlowMetricsSingleton sharedFlowMetricsSingleton;
- private final ClassAliasResolver<SpecCompiler> aliasResolver;
Review Comment:
good call to rescope as method level!
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/utils/FlowCompilationValidationHelper.java:
##########
@@ -59,6 +69,30 @@ public final class FlowCompilationValidationHelper {
private final FlowStatusGenerator flowStatusGenerator;
private final boolean isFlowConcurrencyEnabled;
+ @Inject
+ public FlowCompilationValidationHelper(Config config,
SharedFlowMetricsSingleton sharedFlowMetricsSingleton,
+ UserQuotaManager userQuotaManager, FlowStatusGenerator
flowStatusGenerator) {
+ try {
+ String specCompilerClassName =
ServiceConfigKeys.DEFAULT_GOBBLIN_SERVICE_FLOWCOMPILER_CLASS;
+ if
(config.hasPath(ServiceConfigKeys.GOBBLIN_SERVICE_FLOWCOMPILER_CLASS_KEY)) {
+ specCompilerClassName =
config.getString(ServiceConfigKeys.GOBBLIN_SERVICE_FLOWCOMPILER_CLASS_KEY);
Review Comment:
isn't there a method in `ConfigUtils` (or similar utility) that we could
leverage to provide such fallback to a default?
Issue Time Tracking
-------------------
Worklog Id: (was: 909346)
Time Spent: 2h (was: 1h 50m)
> create instances of new new class created in PR #3858
> -----------------------------------------------------
>
> Key: GOBBLIN-2013
> URL: https://issues.apache.org/jira/browse/GOBBLIN-2013
> Project: Apache Gobblin
> Issue Type: Task
> Reporter: Arjun Singh Bora
> Priority: Major
> Time Spent: 2h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)