phet commented on code in PR #3890:
URL: https://github.com/apache/gobblin/pull/3890#discussion_r1525696695


##########
gobblin-runtime/src/main/java/org/apache/gobblin/scheduler/SchedulerService.java:
##########
@@ -43,33 +43,40 @@
 @Singleton
 public class SchedulerService extends AbstractIdleService {
 
+  private StdSchedulerFactory schedulerFactory;
   @Getter
   private Scheduler scheduler;
   private final boolean waitForJobCompletion;
   private final Optional<Properties> quartzProps;
 
-  public SchedulerService(boolean waitForJobCompletion, Optional<Properties> 
quartzConfig) {
+  public SchedulerService(boolean waitForJobCompletion, Optional<Properties> 
quartzConfig,
+      StdSchedulerFactory schedulerFactory) {
     this.waitForJobCompletion = waitForJobCompletion;
     this.quartzProps = quartzConfig;
+    if (this.schedulerFactory == null) {
+      this.schedulerFactory = new StdSchedulerFactory();

Review Comment:
   I agree in cases like this that it's appropriate to refer to this 
`.impl`-package class.  not such a big deal here within our impl, as it is when 
a type within our interface that client code sees (and may begin to depend upon)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to