phet commented on code in PR #3890:
URL: https://github.com/apache/gobblin/pull/3890#discussion_r1525700500


##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/proc/LaunchDagProc.java:
##########
@@ -193,6 +193,14 @@ private void submitJobToExecutor(DagManagementStateStore 
dagManagementStateStore
   }
 
   @Override
+  protected void commit(DagManagementStateStore dagManagementStateStore, 
Optional<Dag<JobExecutionPlan>> dag) {
+    try {
+      this.launchDagTask.getLeaseObtainedStatus().completeLease();

Review Comment:
   I believe you should implement this in `DagTask::conclude`.  when you do, be 
weary of the override in `LaunchDagTask` - we may not need to retain that



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to