phet commented on code in PR #3890:
URL: https://github.com/apache/gobblin/pull/3890#discussion_r1525733934
##########
gobblin-runtime/src/main/java/org/apache/gobblin/runtime/api/MysqlMultiActiveLeaseArbiter.java:
##########
@@ -237,19 +239,19 @@ private void initializeConstantsTable() throws
IOException {
}
@Override
- public LeaseAttemptStatus tryAcquireLease(DagActionStore.DagAction
flowAction, long eventTimeMillis,
+ public LeaseAttemptStatus tryAcquireLease(DagActionStore.DagAction
dagAction, long eventTimeMillis,
boolean isReminderEvent, boolean adoptConsensusFlowExecutionId) throws
IOException {
log.info("Multi-active scheduler about to handle trigger event: [{}, is:
{}, triggerEventTimestamp: {}]",
- flowAction, isReminderEvent ? "reminder" : "original",
eventTimeMillis);
- // Query lease arbiter table about this flow action
- Optional<GetEventInfoResult> getResult = getExistingEventInfo(flowAction,
isReminderEvent, eventTimeMillis);
+ dagAction, isReminderEvent ? "reminder" : "original", eventTimeMillis);
+ // Query lease arbiter table about this dag action
+ Optional<GetEventInfoResult> getResult = getExistingEventInfo(dagAction,
isReminderEvent, eventTimeMillis);
try {
if (!getResult.isPresent()) {
- log.debug("tryAcquireLease for [{}, is; {}, eventTimestamp: {}] - CASE
1: no existing row for this flow action,"
- + " then go ahead and insert", flowAction, isReminderEvent ?
"reminder" : "original", eventTimeMillis);
- int numRowsUpdated = attemptLeaseIfNewRow(flowAction);
- return evaluateStatusAfterLeaseAttempt(numRowsUpdated, flowAction,
Optional.empty(),
+ log.debug("tryAcquireLease for [{}, is; {}, eventTimestamp: {}] - CASE
1: no existing row for this dag action,"
+ + " then go ahead and insert", dagAction, isReminderEvent ?
"reminder" : "original", eventTimeMillis);
Review Comment:
one thing I appreciate about logging against the `dagAction.toString()`
abstraction is that we needn't update anything about `dagAction.getJobName()`!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]