phet commented on code in PR #3890:
URL: https://github.com/apache/gobblin/pull/3890#discussion_r1525781302


##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/ReminderSettingFlowTriggerLeaseArbiter.java:
##########
@@ -332,4 +303,17 @@ protected static long getUTCTimeFromDelayPeriod(long 
delayPeriodMillis) {
     Date date = Date.from(localDateTime.atZone(ZoneId.of("UTC")).toInstant());
     return GobblinServiceJobScheduler.utcDateAsUTCEpochMillis(date);
   }
+
+  @Override
+  public LeaseAttemptStatus tryAcquireLease(DagActionStore.DagAction 
dagAction, long eventTimeMillis,
+      boolean isReminderEvent, boolean adoptConsensusFlowExecutionId)
+      throws IOException {
+    return this.decoratedLeaseArbiter.tryAcquireLease(dagAction, 
eventTimeMillis, isReminderEvent, adoptConsensusFlowExecutionId);
+  }
+
+  @Override
+  public boolean recordLeaseSuccess(LeaseObtainedStatus status)
+      throws IOException {
+    return this.decoratedLeaseArbiter.recordLeaseSuccess(status);
+  }

Review Comment:
   this class seems a poor fit for the Decorator pattern, as there's no 
decoration going on



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to