Will-Lo commented on code in PR #3890:
URL: https://github.com/apache/gobblin/pull/3890#discussion_r1529121626
##########
gobblin-runtime/src/main/java/org/apache/gobblin/runtime/api/DagActionStore.java:
##########
@@ -51,30 +52,53 @@ public FlowId getFlowId() {
*/
public DagAction updateFlowExecutionId(long eventTimeMillis) {
return new DagAction(this.getFlowGroup(), this.getFlowName(),
- String.valueOf(eventTimeMillis), this.getFlowActionType());
+ String.valueOf(eventTimeMillis), this.getJobName(),
this.getDagActionType());
}
}
/**
- * Check if an action exists in dagAction store by flow group, flow name and
flow execution id.
+ * Check if an action exists in dagAction store by flow group, flow name,
flow execution id, and job name.
* @param flowGroup flow group for the dag action
* @param flowName flow name for the dag action
* @param flowExecutionId flow execution for the dag action
- * @param flowActionType the value of the dag action
+ * @param jobName job name for the dag action
Review Comment:
What's the motivation behind adding jobName to the DagAction? It's derived
from the other 3 fields here, along with the flow edge and a random hash that
is consistent on compilation. Dags should be uniquely identified by the other 3
fields right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]