[
https://issues.apache.org/jira/browse/GOBBLIN-2022?focusedWorklogId=911484&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-911484
]
ASF GitHub Bot logged work on GOBBLIN-2022:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 26/Mar/24 06:17
Start Date: 26/Mar/24 06:17
Worklog Time Spent: 10m
Work Description: phet commented on code in PR #3896:
URL: https://github.com/apache/gobblin/pull/3896#discussion_r1538573516
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/MostlyMySqlDagManagementStateStore.java:
##########
@@ -235,4 +242,16 @@ public void
tryAcquireQuota(Collection<Dag.DagNode<JobExecutionPlan>> dagNodes)
public boolean releaseQuota(Dag.DagNode<JobExecutionPlan> dagNode) throws
IOException {
return this.quotaManager.releaseQuota(dagNode);
}
+
+ @Override
+ public Optional<JobStatus> getJobStatus(String flowGroup, String flowName,
long flowExecutionId, String jobGroup, String jobName) {
+ Iterator<JobStatus> jobStatusIterator =
+ jobStatusRetriever.getJobStatusesForFlowExecution(flowName, flowGroup,
flowExecutionId, jobName, jobGroup);
+
+ if (jobStatusIterator.hasNext()) {
+ return Optional.of(jobStatusIterator.next());
Review Comment:
suggest a comment to describe why you only return the first job status.
what's the meaning/importance of the others that may be skipped?
Issue Time Tracking
-------------------
Worklog Id: (was: 911484)
Time Spent: 3h 40m (was: 3.5h)
> create dag proc for taking actions on job completion
> ----------------------------------------------------
>
> Key: GOBBLIN-2022
> URL: https://issues.apache.org/jira/browse/GOBBLIN-2022
> Project: Apache Gobblin
> Issue Type: Task
> Reporter: Arjun Singh Bora
> Priority: Major
> Time Spent: 3h 40m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
