[
https://issues.apache.org/jira/browse/GOBBLIN-2022?focusedWorklogId=911483&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-911483
]
ASF GitHub Bot logged work on GOBBLIN-2022:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 26/Mar/24 06:17
Start Date: 26/Mar/24 06:17
Worklog Time Spent: 10m
Work Description: phet commented on code in PR #3896:
URL: https://github.com/apache/gobblin/pull/3896#discussion_r1538519673
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/task/DagTask.java:
##########
@@ -42,11 +43,14 @@ public abstract class DagTask {
@Getter public final DagActionStore.DagAction dagAction;
private final MultiActiveLeaseArbiter.LeaseObtainedStatus
leaseObtainedStatus;
@Getter protected final DagManager.DagId dagId;
+ @Getter protected final DagNodeId dagNodeId;
Review Comment:
why store/cache these in a field, rather than just having the impl in:
```
public DagMgr.DagId getDagId() { ... }
```
(which computes it on demand)
?
Issue Time Tracking
-------------------
Worklog Id: (was: 911483)
Time Spent: 3.5h (was: 3h 20m)
> create dag proc for taking actions on job completion
> ----------------------------------------------------
>
> Key: GOBBLIN-2022
> URL: https://issues.apache.org/jira/browse/GOBBLIN-2022
> Project: Apache Gobblin
> Issue Type: Task
> Reporter: Arjun Singh Bora
> Priority: Major
> Time Spent: 3.5h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
