[
https://issues.apache.org/jira/browse/GOBBLIN-2022?focusedWorklogId=911494&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-911494
]
ASF GitHub Bot logged work on GOBBLIN-2022:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 26/Mar/24 06:25
Start Date: 26/Mar/24 06:25
Worklog Time Spent: 10m
Work Description: phet commented on code in PR #3896:
URL: https://github.com/apache/gobblin/pull/3896#discussion_r1538627514
##########
gobblin-service/src/test/java/org/apache/gobblin/service/monitoring/FsJobStatusRetrieverTest.java:
##########
@@ -47,6 +50,8 @@ public void setUp() throws Exception {
.withValue(FsJobStatusRetriever.CONF_PREFIX + "." +
ConfigurationKeys.STATE_STORE_ROOT_DIR_KEY,
ConfigValueFactory.fromAnyRef(stateStoreDir));
this.jobStatusRetriever = new FsJobStatusRetriever(config,
mock(MultiContextIssueRepository.class));
+ this.mysqlDagActionStore = mock(MysqlDagActionStore.class);
+ doNothing().when(this.mysqlDagActionStore).addDagAction(any(), any(),
any(), any());
Review Comment:
from looking at this PR's diff, I can't see why this is necessary. (I also
wouldn't expect to see a mysql store being necessary for a FS retriever test.)
these are strong indications that it deserves a source comment, if not
reworking
Issue Time Tracking
-------------------
Worklog Id: (was: 911494)
Time Spent: 5h 10m (was: 5h)
> create dag proc for taking actions on job completion
> ----------------------------------------------------
>
> Key: GOBBLIN-2022
> URL: https://issues.apache.org/jira/browse/GOBBLIN-2022
> Project: Apache Gobblin
> Issue Type: Task
> Reporter: Arjun Singh Bora
> Priority: Major
> Time Spent: 5h 10m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
