[
https://issues.apache.org/jira/browse/GOBBLIN-2029?focusedWorklogId=912104&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-912104
]
ASF GitHub Bot logged work on GOBBLIN-2029:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 28/Mar/24 19:47
Start Date: 28/Mar/24 19:47
Worklog Time Spent: 10m
Work Description: phet commented on code in PR #3906:
URL: https://github.com/apache/gobblin/pull/3906#discussion_r1543523246
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/core/GobblinServiceGuiceModule.java:
##########
@@ -38,11 +38,7 @@
import javax.inject.Singleton;
import org.apache.gobblin.restli.EmbeddedRestliServer;
-import org.apache.gobblin.service.modules.orchestration.DagActionStore;
import org.apache.gobblin.runtime.api.GobblinInstanceEnvironment;
-import
org.apache.gobblin.service.modules.orchestration.MultiActiveLeaseArbiter;
-import
org.apache.gobblin.service.modules.orchestration.MysqlMultiActiveLeaseArbiter;
-import org.apache.gobblin.service.modules.orchestration.MysqlDagActionStore;
import org.apache.gobblin.runtime.instance.StandardGobblinInstanceLauncher;
import org.apache.gobblin.runtime.spec_catalog.FlowCatalog;
import org.apache.gobblin.runtime.spec_catalog.TopologyCatalog;
Review Comment:
let's please better characterize import order for our code style. the
paltry two bullets at present are imprecise -
https://gobblin.apache.org/docs/developer-guide/CodingStyle/
we ought to specify:
* where `javax.` goes
* where `lombok.` goes
* that `gobblin.` is pretty much in the past, and all replaced by
`org.apache.gobblin.`
* where unit-test-specific imports belong - personally I find it easiest to
read `org.junit.`, `org.testng.`, `org.mockito.` etc. *following* all
"non-test" imports (of what's being tested); I've observed others following
this ordering as well
* that `import static` belongs after `import` (seems common practice at
least...)
* putting `java.` and `javax.` first is typical and customary, but let's
either justify or else drop the seemingly arbitrary guidance to deviate from
alphabetical on:
- `java.`, `org.` (non-gobblin), `com.`, `org.apache.gobblin.`
rather than what would seem much easier for humans to scan:
- `java.`, `com.`, `org.` (non-gobblin), `org.apache.gobblin.`
Issue Time Tracking
-------------------
Worklog Id: (was: 912104)
Time Spent: 20m (was: 10m)
> code style changes DagProc and related classes
> ----------------------------------------------
>
> Key: GOBBLIN-2029
> URL: https://issues.apache.org/jira/browse/GOBBLIN-2029
> Project: Apache Gobblin
> Issue Type: Task
> Reporter: Arjun Singh Bora
> Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)