[
https://issues.apache.org/jira/browse/GOBBLIN-2029?focusedWorklogId=912112&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-912112
]
ASF GitHub Bot logged work on GOBBLIN-2029:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 28/Mar/24 20:04
Start Date: 28/Mar/24 20:04
Worklog Time Spent: 10m
Work Description: arjun4084346 commented on code in PR #3906:
URL: https://github.com/apache/gobblin/pull/3906#discussion_r1543576210
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/proc/DagProcUtils.java:
##########
@@ -0,0 +1,118 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.gobblin.service.modules.orchestration.proc;
+
+import java.io.IOException;
+import java.util.Collections;
+import java.util.List;
+import java.util.Map;
+import java.util.concurrent.Future;
+
+import com.google.common.collect.Maps;
+
+import lombok.extern.slf4j.Slf4j;
+
+import org.apache.gobblin.metrics.event.TimingEvent;
+import org.apache.gobblin.runtime.api.JobSpec;
+import org.apache.gobblin.runtime.api.Spec;
+import org.apache.gobblin.runtime.api.SpecExecutor;
+import org.apache.gobblin.runtime.api.SpecProducer;
+import org.apache.gobblin.service.ExecutionStatus;
+import org.apache.gobblin.service.modules.flowgraph.Dag;
+import
org.apache.gobblin.service.modules.orchestration.DagManagementStateStore;
+import org.apache.gobblin.service.modules.orchestration.DagManager;
+import org.apache.gobblin.service.modules.orchestration.DagManagerUtils;
+import org.apache.gobblin.service.modules.orchestration.TimingEventUtils;
+import org.apache.gobblin.service.modules.spec.JobExecutionPlan;
+
+
+/**
+ * A class to group together all the utility methods used by various dag procs.
+ */
+@Slf4j
+public class DagProcUtils {
+
+ /**
+ * - submits a {@link JobSpec} to a {@link SpecExecutor}
+ * - updates metrics
+ * - add updated dag node state to dagManagementStateStore
+ */
+ static void submitJobToExecutor(DagManagementStateStore
dagManagementStateStore, Dag.DagNode<JobExecutionPlan> dagNode,
Review Comment:
So far only dag procs need it...
Issue Time Tracking
-------------------
Worklog Id: (was: 912112)
Time Spent: 1.5h (was: 1h 20m)
> code style changes DagProc and related classes
> ----------------------------------------------
>
> Key: GOBBLIN-2029
> URL: https://issues.apache.org/jira/browse/GOBBLIN-2029
> Project: Apache Gobblin
> Issue Type: Task
> Reporter: Arjun Singh Bora
> Priority: Major
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)