[
https://issues.apache.org/jira/browse/GOBBLIN-2029?focusedWorklogId=912304&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-912304
]
ASF GitHub Bot logged work on GOBBLIN-2029:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 29/Mar/24 22:45
Start Date: 29/Mar/24 22:45
Worklog Time Spent: 10m
Work Description: phet commented on code in PR #3906:
URL: https://github.com/apache/gobblin/pull/3906#discussion_r1544929527
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/proc/DagProcUtils.java:
##########
@@ -0,0 +1,113 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.gobblin.service.modules.orchestration.proc;
+
+import java.io.IOException;
+import java.util.Collections;
+import java.util.Map;
+import java.util.concurrent.Future;
+
+import com.google.common.collect.Maps;
+
+import lombok.extern.slf4j.Slf4j;
+
+import org.apache.gobblin.metrics.event.TimingEvent;
+import org.apache.gobblin.runtime.api.JobSpec;
+import org.apache.gobblin.runtime.api.Spec;
+import org.apache.gobblin.runtime.api.SpecExecutor;
+import org.apache.gobblin.runtime.api.SpecProducer;
+import org.apache.gobblin.service.ExecutionStatus;
+import org.apache.gobblin.service.modules.flowgraph.Dag;
+import
org.apache.gobblin.service.modules.orchestration.DagManagementStateStore;
+import org.apache.gobblin.service.modules.orchestration.DagManager;
+import org.apache.gobblin.service.modules.orchestration.DagManagerUtils;
+import org.apache.gobblin.service.modules.orchestration.TimingEventUtils;
+import org.apache.gobblin.service.modules.spec.JobExecutionPlan;
+
+
+/**
+ * A class to group together all the utility methods for {@link DagProc}
derived class implementations.
+ */
+@Slf4j
+public class DagProcUtils {
+
+ /**
+ * - submits a {@link JobSpec} to a {@link SpecExecutor}
+ * - emits a {@link TimingEvent.LauncherTimings#JOB_ORCHESTRATED} {@link
org.apache.gobblin.metrics.GobblinTrackingEvent}
Review Comment:
also increments "running jobs" and "jobs sent to executor", but NBD if you
don't want to add
Issue Time Tracking
-------------------
Worklog Id: (was: 912304)
Time Spent: 1h 50m (was: 1h 40m)
> code style changes DagProc and related classes
> ----------------------------------------------
>
> Key: GOBBLIN-2029
> URL: https://issues.apache.org/jira/browse/GOBBLIN-2029
> Project: Apache Gobblin
> Issue Type: Task
> Reporter: Arjun Singh Bora
> Priority: Major
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)