phet commented on code in PR #3931:
URL: https://github.com/apache/gobblin/pull/3931#discussion_r1573050236
##########
gobblin-cluster/src/main/java/org/apache/gobblin/cluster/GobblinClusterConfigurationKeys.java:
##########
@@ -50,6 +50,8 @@ public class GobblinClusterConfigurationKeys {
public static final boolean DEFAULT_STANDALONE_CLUSTER_MODE = false;
// Root working directory for Gobblin cluster
public static final String CLUSTER_WORK_DIR = GOBBLIN_CLUSTER_PREFIX +
"workDir";
+ // Root working dir without appending the application name, keeping
CLUSTER_WORK_DIR property for backward compatibility
+ public static final String CLUSTER_ABSOLUTE_WORK_DIR =
GOBBLIN_CLUSTER_PREFIX + "absolute.workDir";
Review Comment:
not sure if I've missed some critical details here... but who's appending
the job_name to this prop?
in general, my pref wouldn't be to push the uniqueness requirement to the
caller, but rather to encapsulate within here the determination of a job-unique
dir, by taking in a prop for the "base dir" and then auto-appending the
particular job name to that
##########
gobblin-cluster/src/main/java/org/apache/gobblin/cluster/GobblinClusterConfigurationKeys.java:
##########
@@ -50,6 +50,8 @@ public class GobblinClusterConfigurationKeys {
public static final boolean DEFAULT_STANDALONE_CLUSTER_MODE = false;
// Root working directory for Gobblin cluster
public static final String CLUSTER_WORK_DIR = GOBBLIN_CLUSTER_PREFIX +
"workDir";
+ // Root working dir without appending the application name, keeping
CLUSTER_WORK_DIR property for backward compatibility
+ public static final String CLUSTER_ABSOLUTE_WORK_DIR =
GOBBLIN_CLUSTER_PREFIX + "absolute.workDir";
Review Comment:
not sure if I've missed some critical details here... but who's appending
the job_name to this prop?
in general, my pref wouldn't be to push the uniqueness requirement to the
caller, but rather to encapsulate within here the determination of a job-unique
dir, by first taking in a prop for the "base dir" and then auto-appending the
particular job name to that
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
