phet commented on code in PR #3931:
URL: https://github.com/apache/gobblin/pull/3931#discussion_r1578579697
##########
gobblin-yarn/src/main/java/org/apache/gobblin/yarn/GobblinYarnAppLauncher.java:
##########
@@ -885,10 +884,11 @@ private AbstractTokenRefresher buildTokenRefreshManager()
throws IOException {
@VisibleForTesting
void cleanUpAppWorkDirectory(ApplicationId applicationId) throws IOException
{
- Path appWorkDir =
GobblinClusterUtils.getAppWorkDirPathFromConfig(this.config, this.fs,
this.applicationName, applicationId.toString());
- if (this.fs.exists(appWorkDir)) {
+ FileSystem fs =
GobblinClusterUtils.buildNewInstanceFileSystem(this.config,
this.yarnConfiguration);
Review Comment:
what do you think here?
##########
gobblin-cluster/src/main/java/org/apache/gobblin/cluster/GobblinClusterUtils.java:
##########
@@ -254,4 +257,13 @@ public static FileSystem buildFileSystem(Config config,
Configuration conf)
.get(URI.create(config.getString(ConfigurationKeys.FS_URI_KEY)), conf)
: FileSystem.get(conf);
}
+
+ public static FileSystem buildNewInstanceFileSystem(Config config,
Configuration conf) throws IOException {
Review Comment:
nit: `createFileSystem`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
