phet commented on code in PR #3931:
URL: https://github.com/apache/gobblin/pull/3931#discussion_r1573050980
##########
gobblin-cluster/src/main/java/org/apache/gobblin/cluster/GobblinClusterUtils.java:
##########
@@ -131,6 +131,9 @@ public static String getHostname() throws
UnknownHostException {
*/
public static Path getAppWorkDirPathFromConfig(Config config, FileSystem fs,
String applicationName, String applicationId) {
+ if
(config.hasPath(GobblinClusterConfigurationKeys.CLUSTER_EXACT_WORK_DIR)) {
+ return new Path(new Path(fs.getUri()),
config.getString(GobblinClusterConfigurationKeys.CLUSTER_EXACT_WORK_DIR));
+ }
if (config.hasPath(GobblinClusterConfigurationKeys.CLUSTER_WORK_DIR)) {
return new Path(new Path(fs.getUri()),
PathUtils.combinePaths(config.getString(GobblinClusterConfigurationKeys.CLUSTER_WORK_DIR),
Review Comment:
nit: this feels clearer:
```
if (X) {
return A;
} else if (Y) {
return B;
} else {
return C;
}
```
vs.
```
if (X) {
return A;
}
if (Y) {
return B;
}
return C;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
