[
https://issues.apache.org/jira/browse/GOBBLIN-2056?focusedWorklogId=916863&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-916863
]
ASF GitHub Bot logged work on GOBBLIN-2056:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 29/Apr/24 15:14
Start Date: 29/Apr/24 15:14
Worklog Time Spent: 10m
Work Description: Will-Lo commented on code in PR #3937:
URL: https://github.com/apache/gobblin/pull/3937#discussion_r1583251020
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/flow/BaseFlowToJobSpecCompiler.java:
##########
@@ -97,35 +97,13 @@ public abstract class BaseFlowToJobSpecCompiler implements
SpecCompiler {
private Optional<UserQuotaManager> userQuotaManager;
- public BaseFlowToJobSpecCompiler(Config config){
- this(config,true);
- }
-
- public BaseFlowToJobSpecCompiler(Config config, boolean
instrumentationEnabled){
- this(config, Optional.<Logger>absent(), true);
- }
-
- public BaseFlowToJobSpecCompiler(Config config, Optional<Logger> log){
- this(config, log,true);
- }
-
- public BaseFlowToJobSpecCompiler(Config config, Optional<Logger> log,
boolean instrumentationEnabled){
- this.log = log.isPresent() ? log.get() :
LoggerFactory.getLogger(getClass());
- if (instrumentationEnabled) {
Review Comment:
Is the intention here to remove the use of this variable for checking if
instrumentation is enabled? It's still used widely in GaaS modules so there
should be justification
Issue Time Tracking
-------------------
Worklog Id: (was: 916863)
Remaining Estimate: 0h
Time Spent: 10m
> initialize topology specs directly from the configs
> ---------------------------------------------------
>
> Key: GOBBLIN-2056
> URL: https://issues.apache.org/jira/browse/GOBBLIN-2056
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Arjun Singh Bora
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> initialize topology specs directly from the configs instead of waiting for
> the callbacks of topology spec catalog listerners
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
