[
https://issues.apache.org/jira/browse/GOBBLIN-2056?focusedWorklogId=917149&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-917149
]
ASF GitHub Bot logged work on GOBBLIN-2056:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 01/May/24 17:24
Start Date: 01/May/24 17:24
Worklog Time Spent: 10m
Work Description: umustafi commented on code in PR #3937:
URL: https://github.com/apache/gobblin/pull/3937#discussion_r1586537330
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/utils/FlowCompilationValidationHelper.java:
##########
@@ -73,12 +74,12 @@ public class FlowCompilationValidationHelper {
@Inject
public FlowCompilationValidationHelper(Config config,
SharedFlowMetricsSingleton sharedFlowMetricsSingleton,
- UserQuotaManager userQuotaManager, FlowStatusGenerator
flowStatusGenerator) {
Review Comment:
Checking `GobblinServiceManager` start to see how `TopologySpecCatalog` is
populated and it may not have the topologies loaded if it uses the listener
method rather than `TopologySpecFactory.getTopologies()`
https://github.com/apache/gobblin/blob/33660f5d03d703456be73e30ea80d3310457ac7d/gobblin-service/src/main/java/org/apache/gobblin/service/modules/core/GobblinServiceManager.java#L508
One safe guard we can add is both `Orchestrator` and
`SpecCompiler`'s`onAddSpec` method should check `if specCompiler.isActive` is
true before accepting specs to pass to compiler.
https://github.com/apache/gobblin/blob/33660f5d03d703456be73e30ea80d3310457ac7d/gobblin-service/src/main/java/org/apache/gobblin/service/modules/core/GobblinServiceManager.java#L522
Issue Time Tracking
-------------------
Worklog Id: (was: 917149)
Time Spent: 1h (was: 50m)
> initialize topology specs directly from the configs
> ---------------------------------------------------
>
> Key: GOBBLIN-2056
> URL: https://issues.apache.org/jira/browse/GOBBLIN-2056
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Arjun Singh Bora
> Priority: Major
> Time Spent: 1h
> Remaining Estimate: 0h
>
> initialize topology specs directly from the configs instead of waiting for
> the callbacks of topology spec catalog listerners
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
