[
https://issues.apache.org/jira/browse/GOBBLIN-2056?focusedWorklogId=917153&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-917153
]
ASF GitHub Bot logged work on GOBBLIN-2056:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 01/May/24 18:42
Start Date: 01/May/24 18:42
Worklog Time Spent: 10m
Work Description: arjun4084346 commented on code in PR #3937:
URL: https://github.com/apache/gobblin/pull/3937#discussion_r1586634905
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/utils/FlowCompilationValidationHelper.java:
##########
@@ -73,12 +74,12 @@ public class FlowCompilationValidationHelper {
@Inject
public FlowCompilationValidationHelper(Config config,
SharedFlowMetricsSingleton sharedFlowMetricsSingleton,
- UserQuotaManager userQuotaManager, FlowStatusGenerator
flowStatusGenerator) {
Review Comment:
SpecCompiler gets information about topology specs through orchestrator's
onAddSpec. And orchestrator gets info about topology specs because it is a
listener on topology spec catalog.
So compiler has to "wait for topology spec catalog to populate topologies".
topology spec catalog is populated here
https://github.com/apache/gobblin/blob/master/gobblin-service/src/main/java/org/apache/gobblin/service/modules/core/GobblinServiceManager.java#L508
but we may want compiler to have topology information before this code reaches.
Issue Time Tracking
-------------------
Worklog Id: (was: 917153)
Time Spent: 1h 10m (was: 1h)
> initialize topology specs directly from the configs
> ---------------------------------------------------
>
> Key: GOBBLIN-2056
> URL: https://issues.apache.org/jira/browse/GOBBLIN-2056
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Arjun Singh Bora
> Priority: Major
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> initialize topology specs directly from the configs instead of waiting for
> the callbacks of topology spec catalog listerners
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
