umustafi commented on code in PR #3937:
URL: https://github.com/apache/gobblin/pull/3937#discussion_r1583972758
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/utils/FlowCompilationValidationHelper.java:
##########
@@ -73,12 +74,12 @@ public class FlowCompilationValidationHelper {
@Inject
public FlowCompilationValidationHelper(Config config,
SharedFlowMetricsSingleton sharedFlowMetricsSingleton,
- UserQuotaManager userQuotaManager, FlowStatusGenerator
flowStatusGenerator) {
Review Comment:
how do we know the `topologySpecFactory` has been initialized by now?
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/flow/BaseFlowToJobSpecCompiler.java:
##########
@@ -97,35 +97,13 @@ public abstract class BaseFlowToJobSpecCompiler implements
SpecCompiler {
private Optional<UserQuotaManager> userQuotaManager;
- public BaseFlowToJobSpecCompiler(Config config){
- this(config,true);
- }
-
- public BaseFlowToJobSpecCompiler(Config config, boolean
instrumentationEnabled){
- this(config, Optional.<Logger>absent(), true);
- }
-
- public BaseFlowToJobSpecCompiler(Config config, Optional<Logger> log){
- this(config, log,true);
- }
-
- public BaseFlowToJobSpecCompiler(Config config, Optional<Logger> log,
boolean instrumentationEnabled){
- this.log = log.isPresent() ? log.get() :
LoggerFactory.getLogger(getClass());
- if (instrumentationEnabled) {
Review Comment:
Arjun did some refactoring before which made instrumentation required I
believe. Can you link that change to explain what's happening here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
