umustafi commented on code in PR #3937:
URL: https://github.com/apache/gobblin/pull/3937#discussion_r1586537330
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/utils/FlowCompilationValidationHelper.java:
##########
@@ -73,12 +74,12 @@ public class FlowCompilationValidationHelper {
@Inject
public FlowCompilationValidationHelper(Config config,
SharedFlowMetricsSingleton sharedFlowMetricsSingleton,
- UserQuotaManager userQuotaManager, FlowStatusGenerator
flowStatusGenerator) {
Review Comment:
Checking `GobblinServiceManager` start to see how `TopologySpecCatalog` is
populated and it may not have the topologies loaded if it uses the listener
method rather than `TopologySpecFactory.getTopologies()`
https://github.com/apache/gobblin/blob/33660f5d03d703456be73e30ea80d3310457ac7d/gobblin-service/src/main/java/org/apache/gobblin/service/modules/core/GobblinServiceManager.java#L508
One safe guard we can add is both `Orchestrator` and
`SpecCompiler`'s`onAddSpec` method should check `if specCompiler.isActive` is
true before accepting specs to pass to compiler.
https://github.com/apache/gobblin/blob/33660f5d03d703456be73e30ea80d3310457ac7d/gobblin-service/src/main/java/org/apache/gobblin/service/modules/core/GobblinServiceManager.java#L522
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
