[
https://issues.apache.org/jira/browse/GOBBLIN-2056?focusedWorklogId=917186&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-917186
]
ASF GitHub Bot logged work on GOBBLIN-2056:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 01/May/24 20:12
Start Date: 01/May/24 20:12
Worklog Time Spent: 10m
Work Description: phet commented on code in PR #3937:
URL: https://github.com/apache/gobblin/pull/3937#discussion_r1586776782
##########
gobblin-service/src/test/java/org/apache/gobblin/service/modules/orchestration/OrchestratorTest.java:
##########
@@ -244,9 +250,10 @@ public void createTopologySpec() {
}
// Make sure TopologyCatalog is empty
Assert.assertTrue(specs.size() == 0, "Spec store should be empty before
addition");
- // Make sure TopologyCatalog Listener is empty
- Assert.assertTrue(specCompiler.getTopologySpecMap().size() == 0,
"SpecCompiler should not know about any Topology "
- + "before addition");
+ Assert.assertTrue(specCompiler.getTopologySpecMap().size() == 1,
"SpecCompiler should know about any Topology "
+ + " irrespective of what is there in the topology catalog");
+ // Make sure TopologyCatalog empty
+ Assert.assertTrue(this.topologyCatalog.getSize() == 0, "Topology catalog
should contain 0 Spec before addition");
Review Comment:
prior to this change, there's an "inconsistent timespan", where the compiler
doesn't have topo specs initialized. you suggested this might compromise
correctness of `DagManagementStateStore`.
after this change, sounds like there will be an "inconsistent timespan",
where the `TopologyCatalog` may be out of sync w/ the topo specs known to the
compiler. could there be any negative consequence to that?
Issue Time Tracking
-------------------
Worklog Id: (was: 917186)
Time Spent: 3h 40m (was: 3.5h)
> initialize topology specs directly from the configs
> ---------------------------------------------------
>
> Key: GOBBLIN-2056
> URL: https://issues.apache.org/jira/browse/GOBBLIN-2056
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Arjun Singh Bora
> Priority: Major
> Time Spent: 3h 40m
> Remaining Estimate: 0h
>
> initialize topology specs directly from the configs instead of waiting for
> the callbacks of topology spec catalog listerners
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
