[
https://issues.apache.org/jira/browse/GOBBLIN-2056?focusedWorklogId=917162&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-917162
]
ASF GitHub Bot logged work on GOBBLIN-2056:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 01/May/24 19:26
Start Date: 01/May/24 19:26
Worklog Time Spent: 10m
Work Description: arjun4084346 commented on code in PR #3937:
URL: https://github.com/apache/gobblin/pull/3937#discussion_r1586717102
##########
gobblin-service/src/test/java/org/apache/gobblin/service/modules/orchestration/OrchestratorTest.java:
##########
@@ -244,9 +250,10 @@ public void createTopologySpec() {
}
// Make sure TopologyCatalog is empty
Assert.assertTrue(specs.size() == 0, "Spec store should be empty before
addition");
- // Make sure TopologyCatalog Listener is empty
- Assert.assertTrue(specCompiler.getTopologySpecMap().size() == 0,
"SpecCompiler should not know about any Topology "
- + "before addition");
+ Assert.assertTrue(specCompiler.getTopologySpecMap().size() == 1,
"SpecCompiler should know about any Topology "
Review Comment:
"SpecCompiler should know about any Topology irrespective of what is there
in the topology catalog" ? how does that sound like test should be `>1` ? What
description do you suggest?
There is no precondition. SpecCompiler should just know about the
topologies. Number of topologies known to spec compiler should just always be 1
(equals to total number of topologies).
Issue Time Tracking
-------------------
Worklog Id: (was: 917162)
Time Spent: 2h (was: 1h 50m)
> initialize topology specs directly from the configs
> ---------------------------------------------------
>
> Key: GOBBLIN-2056
> URL: https://issues.apache.org/jira/browse/GOBBLIN-2056
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Arjun Singh Bora
> Priority: Major
> Time Spent: 2h
> Remaining Estimate: 0h
>
> initialize topology specs directly from the configs instead of waiting for
> the callbacks of topology spec catalog listerners
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
