[
https://issues.apache.org/jira/browse/GOBBLIN-2056?focusedWorklogId=917171&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-917171
]
ASF GitHub Bot logged work on GOBBLIN-2056:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 01/May/24 19:41
Start Date: 01/May/24 19:41
Worklog Time Spent: 10m
Work Description: phet commented on code in PR #3937:
URL: https://github.com/apache/gobblin/pull/3937#discussion_r1586737313
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/flow/BaseFlowToJobSpecCompiler.java:
##########
@@ -219,8 +199,6 @@ private AddSpecResponse onAddFlowSpec(FlowSpec flowSpec) {
public AddSpecResponse onAddSpec(Spec addedSpec) {
if (addedSpec instanceof FlowSpec) {
return onAddFlowSpec((FlowSpec) addedSpec);
- } else if (addedSpec instanceof TopologySpec) {
- return onAddTopologySpec( (TopologySpec) addedSpec);
Review Comment:
I equate topologies w/ executors in the flow graph. since the FG can change
dynamically w/o requiring a system restart, it doesn't seem out of the question
to change the set of topos w/o a system restart either.
I agree that's not what we've done thus far, but it's arguably inconvenient
to require two separate changes to define a new executor - one to the FG and
one to the gaas configs. if it were possible to do both together, I would
personally find that appealing
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/flow/BaseFlowToJobSpecCompiler.java:
##########
@@ -219,8 +199,6 @@ private AddSpecResponse onAddFlowSpec(FlowSpec flowSpec) {
public AddSpecResponse onAddSpec(Spec addedSpec) {
if (addedSpec instanceof FlowSpec) {
return onAddFlowSpec((FlowSpec) addedSpec);
- } else if (addedSpec instanceof TopologySpec) {
- return onAddTopologySpec( (TopologySpec) addedSpec);
Review Comment:
I equate topology specs w/ executors in the flow graph. since the FG can
change dynamically w/o requiring a system restart, it doesn't seem out of the
question to change the set of topos w/o a system restart either.
I agree that's not what we've done thus far, but it's arguably inconvenient
to require two separate changes to define a new executor - one to the FG and
one to the gaas configs. if it were possible to do both together, I would
personally find that appealing
Issue Time Tracking
-------------------
Worklog Id: (was: 917171)
Time Spent: 2h 50m (was: 2h 40m)
> initialize topology specs directly from the configs
> ---------------------------------------------------
>
> Key: GOBBLIN-2056
> URL: https://issues.apache.org/jira/browse/GOBBLIN-2056
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Arjun Singh Bora
> Priority: Major
> Time Spent: 2h 50m
> Remaining Estimate: 0h
>
> initialize topology specs directly from the configs instead of waiting for
> the callbacks of topology spec catalog listerners
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
