[
https://issues.apache.org/jira/browse/GOBBLIN-2068?focusedWorklogId=919406&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-919406
]
ASF GitHub Bot logged work on GOBBLIN-2068:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 14/May/24 23:18
Start Date: 14/May/24 23:18
Worklog Time Spent: 10m
Work Description: homatthew commented on code in PR #3949:
URL: https://github.com/apache/gobblin/pull/3949#discussion_r1600771410
##########
gobblin-iceberg/src/main/java/org/apache/gobblin/iceberg/publisher/GobblinMCEPublisher.java:
##########
@@ -115,9 +115,11 @@ public void publishData(Collection<? extends
WorkUnitState> states) throws IOExc
}
protected Map<String, String> getPartitionOffsetRange(String offsetKey) {
- return state.getPropAsList(offsetKey)
Review Comment:
A common idiomatic way of handling this nullable case is
```
Optional.ofNullable(...)
.orElseGet(Collections::emptyList)
.stream()
```
##########
gobblin-iceberg/src/main/java/org/apache/gobblin/iceberg/publisher/GobblinMCEPublisher.java:
##########
@@ -115,9 +115,11 @@ public void publishData(Collection<? extends
WorkUnitState> states) throws IOExc
}
protected Map<String, String> getPartitionOffsetRange(String offsetKey) {
- return state.getPropAsList(offsetKey)
Review Comment:
Fun Fact: A common idiomatic way of handling this nullable case is
```
Optional.ofNullable(...)
.orElseGet(Collections::emptyList)
.stream()
```
Issue Time Tracking
-------------------
Worklog Id: (was: 919406)
Time Spent: 20m (was: 10m)
> Make offset range in Gobblin Metadata pipeline configurable
> -----------------------------------------------------------
>
> Key: GOBBLIN-2068
> URL: https://issues.apache.org/jira/browse/GOBBLIN-2068
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Zihan Li
> Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Make offset range in Gobblin Metadata pipeline configurable, as in some case,
> offset range might not be supported
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
