[
https://issues.apache.org/jira/browse/GOBBLIN-2068?focusedWorklogId=919613&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-919613
]
ASF GitHub Bot logged work on GOBBLIN-2068:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 15/May/24 23:23
Start Date: 15/May/24 23:23
Worklog Time Spent: 10m
Work Description: ZihanLi58 commented on code in PR #3949:
URL: https://github.com/apache/gobblin/pull/3949#discussion_r1602353735
##########
gobblin-iceberg/src/main/java/org/apache/gobblin/iceberg/publisher/GobblinMCEPublisher.java:
##########
@@ -115,9 +115,11 @@ public void publishData(Collection<? extends
WorkUnitState> states) throws IOExc
}
protected Map<String, String> getPartitionOffsetRange(String offsetKey) {
- return state.getPropAsList(offsetKey)
Review Comment:
I actually want to return null instead of an empty list in this case. to
make sure I won't call mergeOffset() at all in the icebergMetadataWriter. But
learned this new API. Also getPropAsList() will throw NPE in this case as well
Issue Time Tracking
-------------------
Worklog Id: (was: 919613)
Time Spent: 1h (was: 50m)
> Make offset range in Gobblin Metadata pipeline configurable
> -----------------------------------------------------------
>
> Key: GOBBLIN-2068
> URL: https://issues.apache.org/jira/browse/GOBBLIN-2068
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Zihan Li
> Priority: Major
> Time Spent: 1h
> Remaining Estimate: 0h
>
> Make offset range in Gobblin Metadata pipeline configurable, as in some case,
> offset range might not be supported
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
