[
https://issues.apache.org/jira/browse/GOBBLIN-2068?focusedWorklogId=919407&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-919407
]
ASF GitHub Bot logged work on GOBBLIN-2068:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 14/May/24 23:25
Start Date: 14/May/24 23:25
Worklog Time Spent: 10m
Work Description: homatthew commented on code in PR #3949:
URL: https://github.com/apache/gobblin/pull/3949#discussion_r1600775244
##########
gobblin-modules/gobblin-kafka-common/src/main/java/org/apache/gobblin/source/extractor/extract/kafka/KafkaUtils.java:
##########
@@ -89,11 +89,15 @@ public static List<KafkaPartition> getPartitions(State
state) {
if
(!state.contains(KafkaUtils.getPartitionPropName(KafkaSource.PARTITION_ID, i)))
{
break;
}
- KafkaPartition partition = new
KafkaPartition.Builder().withTopicName(topicName)
-
.withId(state.getPropAsInt(KafkaUtils.getPartitionPropName(KafkaSource.PARTITION_ID,
i)))
-
.withLeaderId(state.getPropAsInt(KafkaUtils.getPartitionPropName(KafkaSource.LEADER_ID,
i)))
-
.withLeaderHostAndPort(state.getProp(KafkaUtils.getPartitionPropName(KafkaSource.LEADER_HOSTANDPORT,
i)))
- .build();
+ KafkaPartition.Builder builder = new
KafkaPartition.Builder().withTopicName(topicName)
+
.withId(state.getPropAsInt(KafkaUtils.getPartitionPropName(KafkaSource.PARTITION_ID,
i)));
+ if
(state.contains(KafkaUtils.getPartitionPropName(KafkaSource.LEADER_ID, i))) {
Review Comment:
I'd favor not copy pasting the
`KafkaUtils.getPartitionPropName(KafkaSource.LEADER_ID, i)` but that is just
me. Also, I assume that kafka utils cannot be null right?
Issue Time Tracking
-------------------
Worklog Id: (was: 919407)
Time Spent: 0.5h (was: 20m)
> Make offset range in Gobblin Metadata pipeline configurable
> -----------------------------------------------------------
>
> Key: GOBBLIN-2068
> URL: https://issues.apache.org/jira/browse/GOBBLIN-2068
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Zihan Li
> Priority: Major
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Make offset range in Gobblin Metadata pipeline configurable, as in some case,
> offset range might not be supported
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
