[
https://issues.apache.org/jira/browse/GOBBLIN-2134?focusedWorklogId=933876&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-933876
]
ASF GitHub Bot logged work on GOBBLIN-2134:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 09/Sep/24 22:05
Start Date: 09/Sep/24 22:05
Worklog Time Spent: 10m
Work Description: phet commented on code in PR #4049:
URL: https://github.com/apache/gobblin/pull/4049#discussion_r1750964026
##########
gobblin-restli/gobblin-flow-config-service/gobblin-flow-config-service-api/src/main/pegasus/org/apache/gobblin/service/ExecutionStatus.pdl:
##########
@@ -49,4 +49,9 @@ enum ExecutionStatus {
* Flow cancelled.
*/
CANCELLED
+
+ /**
+ * Flow or job is skipped
Review Comment:
how would a flow be skipped? wouldn't the flow instead be CANCELLED or
FAILED? after that (fewer than all of) that flow's jobs may be SKIPPED (fewer,
because at least one would be CANCELLED or FAILED)
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/DagUtils.java:
##########
@@ -164,7 +164,8 @@ public static Set<DagNode<JobExecutionPlan>>
getNext(Dag<JobExecutionPlan> dag)
DagNode<JobExecutionPlan> node = nodesToExpand.poll();
ExecutionStatus executionStatus = getExecutionStatus(node);
boolean addFlag = true;
- if (executionStatus == PENDING || executionStatus == PENDING_RETRY ||
executionStatus == PENDING_RESUME) {
+ if (executionStatus == PENDING || executionStatus == PENDING_RETRY ||
executionStatus == PENDING_RESUME ||
+ executionStatus == SKIPPED) {
Review Comment:
I'm unclear here: is "skipping" able to be reversed, so the node can later
be ready? (I'm equating `getNext` to identifying the set of "ready" nodes.)
Issue Time Tracking
-------------------
Worklog Id: (was: 933876)
Time Spent: 1h 10m (was: 1h)
> update job status to SKIPPED for all the dependent jobs of a cancelled job
> --------------------------------------------------------------------------
>
> Key: GOBBLIN-2134
> URL: https://issues.apache.org/jira/browse/GOBBLIN-2134
> Project: Apache Gobblin
> Issue Type: Bug
> Reporter: Arjun Singh Bora
> Priority: Major
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
