[
https://issues.apache.org/jira/browse/GOBBLIN-2134?focusedWorklogId=934350&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-934350
]
ASF GitHub Bot logged work on GOBBLIN-2134:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 11/Sep/24 20:13
Start Date: 11/Sep/24 20:13
Worklog Time Spent: 10m
Work Description: arjun4084346 commented on code in PR #4049:
URL: https://github.com/apache/gobblin/pull/4049#discussion_r1755524989
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/proc/ReevaluateDagProc.java:
##########
@@ -159,9 +164,12 @@ private void onJobFinish(DagManagementStateStore
dagManagementStateStore, Dag.Da
dag.setMessage("Flow failed because job " + jobName + " failed");
dag.setFlowEvent(TimingEvent.FlowTimings.FLOW_FAILED);
dagManagementStateStore.getDagManagerMetrics().incrementExecutorFailed(dagNode);
+ DagProcUtils.sendSkippedEventForDependentJobs(dag, dagNode);
break;
case CANCELLED:
+ case SKIPPED:
Review Comment:
ah, yes this needs to be removed. in a draft version, i was emitting skipped
events only for the child jobs not for all the dependent jobs.
Issue Time Tracking
-------------------
Worklog Id: (was: 934350)
Time Spent: 1h 40m (was: 1.5h)
> update job status to SKIPPED for all the dependent jobs of a cancelled job
> --------------------------------------------------------------------------
>
> Key: GOBBLIN-2134
> URL: https://issues.apache.org/jira/browse/GOBBLIN-2134
> Project: Apache Gobblin
> Issue Type: Bug
> Reporter: Arjun Singh Bora
> Priority: Major
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
