[
https://issues.apache.org/jira/browse/GOBBLIN-2134?focusedWorklogId=934346&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-934346
]
ASF GitHub Bot logged work on GOBBLIN-2134:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 11/Sep/24 20:04
Start Date: 11/Sep/24 20:04
Worklog Time Spent: 10m
Work Description: arjun4084346 commented on code in PR #4049:
URL: https://github.com/apache/gobblin/pull/4049#discussion_r1755512666
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/DagUtils.java:
##########
@@ -164,7 +164,8 @@ public static Set<DagNode<JobExecutionPlan>>
getNext(Dag<JobExecutionPlan> dag)
DagNode<JobExecutionPlan> node = nodesToExpand.poll();
ExecutionStatus executionStatus = getExecutionStatus(node);
boolean addFlag = true;
- if (executionStatus == PENDING || executionStatus == PENDING_RETRY ||
executionStatus == PENDING_RESUME) {
+ if (executionStatus == PENDING || executionStatus == PENDING_RETRY ||
executionStatus == PENDING_RESUME ||
+ executionStatus == SKIPPED) {
Review Comment:
no , skipped cannot not be reversed. this diff should not be here, ill
change it. i think it might be appropriate in some draft version of this PR,
but not anymore
Issue Time Tracking
-------------------
Worklog Id: (was: 934346)
Time Spent: 1.5h (was: 1h 20m)
> update job status to SKIPPED for all the dependent jobs of a cancelled job
> --------------------------------------------------------------------------
>
> Key: GOBBLIN-2134
> URL: https://issues.apache.org/jira/browse/GOBBLIN-2134
> Project: Apache Gobblin
> Issue Type: Bug
> Reporter: Arjun Singh Bora
> Priority: Major
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
