shirshanka commented on a change in pull request #2609: GOBBLIN-744: Support cancellation of a Helix workflow via a DELETE Spec. URL: https://github.com/apache/incubator-gobblin/pull/2609#discussion_r277182277
########## File path: gobblin-cluster/src/main/java/org/apache/gobblin/cluster/GobblinClusterConfigurationKeys.java ########## @@ -159,4 +159,7 @@ public static final String KILL_DUPLICATE_PLANNING_JOB = GOBBLIN_CLUSTER_PREFIX + "kill.duplicate.planningJob"; public static final boolean DEFAULT_KILL_DUPLICATE_PLANNING_JOB = true; + public static final String SHOULD_CANCEL_RUNNING_JOB_ON_DELETE = GOBBLIN_CLUSTER_PREFIX + "shouldCancelRunningJobOnDelete"; + Review comment: Add the default value for this config here (following the standard gobblin pattern) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
