shirshanka commented on a change in pull request #2609: GOBBLIN-744: Support
cancellation of a Helix workflow via a DELETE Spec.
URL: https://github.com/apache/incubator-gobblin/pull/2609#discussion_r277402811
##########
File path:
gobblin-cluster/src/main/java/org/apache/gobblin/cluster/GobblinHelixJobScheduler.java
##########
@@ -116,7 +119,8 @@ public GobblinHelixJobScheduler(Properties properties,
this.jobCatalog = jobCatalog;
this.metricContext = Instrumented.getMetricContext(new
org.apache.gobblin.configuration.State(properties), this.getClass());
- int metricsWindowSizeInMin =
ConfigUtils.getInt(ConfigUtils.propertiesToConfig(this.properties),
+ Config jobConfig = ConfigUtils.propertiesToConfig(this.properties);
Review comment:
This should be the recommended pattern, so we can use ConfigUtils for the
rest of the config gets, without incurring repeated txformations between
properties and Config.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
